[Webkit-unassigned] [Bug 228363] [Win][Uniscribe] Implement Font::applyTransforms

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=228363

--- Comment #2 from Myles C. Maxfield <mmaxfield at apple.com> ---
Comment on attachment 434314
  --> https://bugs.webkit.org/attachment.cgi?id=434314
WIP patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434314&action=review

> Source/WebCore/platform/graphics/win/ComplexTextControllerUniscribe.cpp:293
> +        // state.fOverrideDirection = ?

We may need to pass this information inside the TextRun?

> Source/WebCore/platform/graphics/win/ComplexTextControllerUniscribe.cpp:323
> +        if (!shapeByUniscribe(str, length, item, this, glyphs, clusters, visualAttributes))

I suppose we'll need to create a ComplexTextControllerUniscribe.h to include the signature of this function?

> Source/WebCore/platform/graphics/win/ComplexTextControllerUniscribe.cpp:353
> +            const float cLogicalScale = platformData().useGDI() ? 1 : 32;

Is this really correct?

> Source/WebCore/platform/graphics/win/ComplexTextControllerUniscribe.cpp:362
> +                advance = roundf(advance);
> +                offsetX = roundf(offsetX);
> +                offsetY = roundf(offsetY);

This is almost certainly not necessary (any more).

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210728/f21c7653/attachment.htm>