[Webkit-unassigned] [Bug 228009] Add key-driven smooth scrolling to macOS

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 27 15:15:33 PDT 2021


Tim Horton <thorton at apple.com> changed:

           What    |Removed                     |Added
 Attachment #434249|review?                     |review+
              Flags|                            |

--- Comment #15 from Tim Horton <thorton at apple.com> ---
Comment on attachment 434249
  --> https://bugs.webkit.org/attachment.cgi?id=434249

View in context: https://bugs.webkit.org/attachment.cgi?id=434249&action=review

> Source/WebCore/page/EventHandler.cpp:3807
> +    if (event.type() == eventNames().keyupEvent)
> +        stopKeyboardScrolling();

It is odd that this one doesn't follow the pattern of the others (passing it to editor first, bailing if it ate the event). On the other hand, we know that we never got here with keyup before, so I assume editor's handleKeyboardEvent doesn't do anything with keyup? (please check) But in that case, maybe it's best to follow the pattern anyway to minimize surprise later. Would be interested to hear other people's opinions.

> Source/WebCore/platform/KeyboardScrollingAnimator.h:42
> +    void handleKeyUpEventWhileScrolling();

The caller doesn't actually know that this is "while scrolling", right, they're just plumbing us every keyup? So maybe drop to just "handleKeyUpEvent". The class name indicates who's handling it and why sufficiently.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210727/ab84335f/attachment.htm>

More information about the webkit-unassigned mailing list