[Webkit-unassigned] [Bug 228009] Add key-driven smooth scrolling to macOS

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=228009

Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #434144|review?                     |review+
              Flags|                            |

--- Comment #13 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 434144
  --> https://bugs.webkit.org/attachment.cgi?id=434144
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=434144&action=review

> Source/WebCore/page/EventHandler.cpp:3809
> +    if (event.type() == eventNames().keyupEvent) {
> +        FrameView* view = m_frame.view();
> +        return view->scrollAnimator().keyboardScrollingAnimator()->handleKeyUpEventWhileScrolling();
> +    }

It's a bit weird that the call to beginKeyboardScrollGesture() is hidden down in handleKeyboardScrolling but handleKeyUpEventWhileScrolling() is handled here. Would be nice to make them more symmetrical.

> Source/WebCore/platform/KeyboardScrollingAnimator.cpp:98
> +

Remove this blank line.

> Source/WebCore/platform/KeyboardScrollingAnimator.cpp:104
> +

Same

> Source/WebCore/platform/KeyboardScrollingAnimator.cpp:121
> +    auto springForce = - displacement.scaled(params.springStiffness) - m_velocity.scaled(params.springDamping);

No space after the leading '-'

> Source/WebCore/platform/KeyboardScrollingAnimator.cpp:158
> +    RELEASE_ASSERT_NOT_REACHED();

No need for this to be a RELEASE assert. Just return 0.

> Source/WebCore/platform/KeyboardScrollingAnimator.cpp:196
> +        RELEASE_ASSERT_NOT_REACHED();

don't release assert.

> Source/WebCore/platform/KeyboardScrollingAnimator.cpp:212
> +        RELEASE_ASSERT_NOT_REACHED();

don't release assert.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210726/5af773f4/attachment.htm>