[Webkit-unassigned] [Bug 228009] Add key-driven smooth scrolling to macOS

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=228009

--- Comment #9 from Tim Horton <thorton at apple.com> ---
Comment on attachment 433969
  --> https://bugs.webkit.org/attachment.cgi?id=433969
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433969&action=review

>> Source/WebCore/page/EventHandler.cpp:4323
>> +    return view->scrollAnimator().beginKeyboardScrollAnimation(scroll, event);
> 
> Are we always beginning here, or might the animation already be running from a previous event?

It's the beginning /of a scroll/ (or a scroll gesture, or whatever you want to call it), but you're right, the animation might already be running.

>> Source/WebCore/platform/ScrollAnimator.cpp:316
>> +            axesToApplySpring = perpendicularAbsoluteUnitVector(direction);
> 
> Why is anything happening on the perpendicular axis? Wouldn't a keyboard scroll just be on one axis?

(It took me a while to re-figure this out: while the key is down, the spring is not engaged in the axis of scrolling motion (instead, the force comes from the key), but we still want to let previous animations that might have stretched the string perpendicular to the current animation keep running to completion.)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210722/3af9b3ea/attachment.htm>