[Webkit-unassigned] [Bug 228009] Add key-driven smooth scrolling to macOS

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 19 13:41:53 PDT 2021


https://bugs.webkit.org/show_bug.cgi?id=228009

--- Comment #3 from Aditya Keerthi <akeerthi at apple.com> ---
Comment on attachment 433709
  --> https://bugs.webkit.org/attachment.cgi?id=433709
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=433709&action=review

> Source/WebCore/platform/mac/ScrollAnimatorMac.h:34
> +#include "FrameView.h"

I don't think this import is necessary?

> Source/WebCore/platform/mac/ScrollAnimatorMac.mm:158
> +        IntPoint newPosition = IntPoint((currentPosition() + m_currentScroll->offset).x(), (currentPosition() + m_currentScroll->offset).y());

This can be `auto newPosition = IntPoint(currentPosition() + m_currentScroll->offset);`.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210719/ae9d1234/attachment-0001.htm>


More information about the webkit-unassigned mailing list