[Webkit-unassigned] [Bug 220720] REGRESSION(r271444) [WPE] fast/canvas/webgl/oes-vertex-array-object.html is failing

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jul 17 04:30:15 PDT 2021


https://bugs.webkit.org/show_bug.cgi?id=220720

--- Comment #4 from Eleni Maria Stea <estea at igalia.com> ---
I think that this test should be removed as it is based in the incorrect assumption that deleted buffer names remain valid until the object they used to refer to is destroyed. 

According to the WebGL spec (this paragraph is present in 1.0.0 and on):
https://www.khronos.org/registry/webgl/specs/1.0.3/ 

section: 5.14.5 isBuffer "Return false if the buffer's invalidated flag is set", this is not true and names become invalid immediately.

So, the correct behavior is that after the user calls deleteBuffer the buffer is invalidated (== marked as deleted), although it is still valid, and isBuffer returns false. If you check the WebGL implementation of isBuffer, we return false when the object is marked as deleted (m_deleted is true) which is the correct behavior, and that's why the incorrect test fails.


This patch together with this fix (WIP the MacOSX problem in comments): https://bugs.webkit.org/show_bug.cgi?id=96828 fix make the vertex array OES tests pass.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210717/791536be/attachment.htm>


More information about the webkit-unassigned mailing list