[Webkit-unassigned] [Bug 227866] New: [MSE] CompletionHandler may not always be called in SourceBufferPrivate::didReceiveInitializationSegment

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=227866

            Bug ID: 227866
           Summary: [MSE] CompletionHandler may not always be called in
                    SourceBufferPrivate::didReceiveInitializationSegment
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Media
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: jean-yves.avenard at apple.com

If the initialisation segment received in SourceBufferPrivate::didReceiveInitializationSegment is invalid; then the CompletionHandler will not be called; which would assert in the CompletionHandler destructor
void SourceBufferPrivate::didReceiveInitializationSegment(SourceBufferPrivateClient::InitializationSegment&& segment, CompletionHandler<void()>&& completionHandler)
{
    if (!m_client) {
        completionHandler();
        return;
    }

    if (m_receivedFirstInitializationSegment && !validateInitializationSegment(segment)) {
        m_client->sourceBufferPrivateAppendError(true);
        return;
    }
...
}


if validateInitializationSegment(segment) returns false; then we will error, and return. But this would assert once completionHandler goes out of scope.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210712/3712279e/attachment.htm>