[Webkit-unassigned] [Bug 227738] Defend against stack overflow in GraphicsLayerCA::recursiveCommitChanges

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 6 23:49:02 PDT 2021


--- Comment #2 from Cameron McCormack (:heycam) <heycam at apple.com> ---
All CommitState::treeDepth does currently is avoid hooking up the too-deep PlatformCALayers to their intended parents.  I'm slightly concerned with leaving other aspects of the PlatformCALayers out of date, though most of the LayerChange reasons are just about rendering, geometry, etc., and shouldn't be a big deal, especially when not hooked up.  ScrollingNodeChanged is a bit different, but we tend to check for scrolling node ID validity when we use them.

Another concern is that the treeDepth counts structural layers, and so a given GraphicsLayerCA may be too deep in one call to recursiveCommitChanges, and not be too deep the next.  In such a case we should then continue to process the old m_uncommittedChanges on the children, so that should be OK?

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210707/8c76aadb/attachment.htm>

More information about the webkit-unassigned mailing list