[Webkit-unassigned] [Bug 227726] _WKWebAuthenticationPanel is returning the wrong operation type in clientDataJSON

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 6 15:37:27 PDT 2021


https://bugs.webkit.org/show_bug.cgi?id=227726

Brent Fulgham <bfulgham at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bfulgham at webkit.org

--- Comment #3 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 432981
  --> https://bugs.webkit.org/attachment.cgi?id=432981
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=432981&action=review

We should test that the clientDataJSON is returning the right thing. Could you add a TestWebKitAPI test to OpenSource/Tools/TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm that confirms that the JSON blob is right?

> Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm:526
> +    auto clientDataJSON = produceClientDataJson(_WKWebAuthenticationTypeGet, challenge, origin);

Oops!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210706/13e6a181/attachment.htm>


More information about the webkit-unassigned mailing list