[Webkit-unassigned] [Bug 227724] _WKWebAuthenticationPanel escapes slashes in origin

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 6 15:35:11 PDT 2021


Brent Fulgham <bfulgham at webkit.org> changed:

           What    |Removed                     |Added
                 CC|                            |bfulgham at webkit.org

--- Comment #3 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 432979
  --> https://bugs.webkit.org/attachment.cgi?id=432979

View in context: https://bugs.webkit.org/attachment.cgi?id=432979&action=review

> Source/WebKit/UIProcess/API/Cocoa/_WKWebAuthenticationPanel.mm:76
> +    return [NSJSONSerialization dataWithJSONObject:dictionary.get() options:(NSJSONWritingSortedKeys | NSJSONWritingWithoutEscapingSlashes) error:nil];

Seems like we should add a test of some kind to make sure we don't break this.

Could you add a TestWebKitAPI test to OpenSource/Tools/TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm that confirms that the JSON blob is right?

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210706/d2048d1f/attachment-0001.htm>

More information about the webkit-unassigned mailing list