[Webkit-unassigned] [Bug 221070] New: [Flatpak SDK] Flatpak environment JSON is prematurely deleted with flatpak-spawn calls

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=221070

            Bug ID: 221070
           Summary: [Flatpak SDK] Flatpak environment JSON is prematurely
                    deleted with flatpak-spawn calls
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: lmoura at igalia.com

r271938 added a flatpak_env.json file to forward some variables to webkit-bwrap after flatpak 1.10 changes.

This is working fine most of the time, but if flatpak-spawn is used to invoke a command from the host into the flatpak again (e.g. calling coredumpctl when a layout test fails), the new webkit-flatpak invocation may overwrite the file and delete it when exiting.

This could cause the finally block in the first flatpak process to fail with:

Traceback (most recent call last):
  File "./Tools/Scripts/run-webkit-tests", line 42, in <module>
    flatpakutils.run_in_sandbox_if_available(sys.argv)
  File "./Tools/flatpak/flatpakutils.py", line 1124, in run_in_sandbox_if_available
    sys.exit(flatpak_runner.run_in_sandbox(*app_args))
  File "./Tools/flatpak/flatpakutils.py", line 877, in run_in_sandbox
    os.remove(env_file)
OSError: [Errno 2] No such file or directory: '/home/lauro/dev/WebKit/WebKitBuild/flatpak-env.json'

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210128/f84362c1/attachment-0001.htm>