[Webkit-unassigned] [Bug 220955] Crash from CompositeEditCommand::moveParagraphs() using Position instead of VisiblePosition

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=220955

--- Comment #4 from Julian Gonzalez <julian_a_gonzalez at apple.com> ---
(In reply to Ryosuke Niwa from comment #3)
> Comment on attachment 418346 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=418346&action=review
> 
> > LayoutTests/editing/inserting/paragraph-outdent-animationframe-crash.html:20
> > +    document.execCommand("selectAll", false);
> > +    window.requestAnimationFrame(dooutdent);
> 
> I think the test failure comes from this code running after this test had
> finished running.
> You need to add testRunner.waitUntilDone where you call dumpAsText,
> and call testRunner.notifyDone when the test is done running perhaps at the
> end of dooutdent?
> Be sure to verify that the crash still reproduces without the fix if you
> made those changes to the test.

This ended up being a little more complicated, but Ryosuke figured it out. Thanks to him for cleaning the test up!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210128/f89cddb9/attachment.htm>