[Webkit-unassigned] [Bug 220993] REGRESSION(r270637) Filtering does not work in Styles sidebar panel

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=220993

Devin Rousso <drousso at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #418448|review?                     |review+
              Flags|                            |

--- Comment #4 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 418448
  --> https://bugs.webkit.org/attachment.cgi?id=418448
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418448&action=review

r=me with a recommended alternative

> Source/WebInspectorUI/ChangeLog:9
> +        Reverting removal of abstract method used by SpreadsheetRulesStyleDetailsPanel.

I think we should just remove the `super.filterDidChange(filterBar);` call in `ComputedStyleDetailsPanel.js`.  `WI.GeneralStyleDetailsSidebarPanel.prototype.initialLayout` checks for `typeof this._panel.filterDidChange === "function"`, so it may be better to remove it from the superclass in case we add new subclasses that don't actually override it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210126/ff1c4778/attachment.htm>