[Webkit-unassigned] [Bug 220925] [webkit-patch] Allow user to opt out of browser for viewing the diff

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=220925

--- Comment #13 from Angelos Oikonomopoulos <angelos at igalia.com> ---
(In reply to Angelos Oikonomopoulos from comment #7)
> (In reply to Sam Weinig from comment #4)
> > Comment on attachment 418293 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=418293&action=review
> > 
> > > Tools/Scripts/webkitpy/common/system/user.py:174
> > > +        if os.environ.get("WEBKIT_PATCH_NO_BROWSER"):
> > 
> > This seems reasonably, but I think we would want this to have also be
> > configurable via an argument and documented in the help text, as an
> > environment variable is not very discoverable.
> 
> The discoverability is a good point. TBH adding an option for this felt a
> little heavy-weight and mentioning the environment variable in the help text
> seems even less subtle. Yet I imagine in most cases the user would want to
> set the environment variable rather than pass in a flag for every
> invocation. So if we want to make this discoverable, sounds like this is the
> way to go.

Not sure how to best handle this. AFAIU adding this flag and propagating it to ConfirmDiff seems like a pretty invasive change for something this trivial. I guuess Ican look into that, but is it worth the trade off in added complexity?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210126/6a57580a/attachment-0001.htm>