[Webkit-unassigned] [Bug 220349] Nullptr crash in editingIgnoresContent via InsertParagraphSeparatorCommand::doApply

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=220349

--- Comment #10 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 418266
  --> https://bugs.webkit.org/attachment.cgi?id=418266
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418266&action=review

> Source/WebCore/editing/InsertParagraphSeparatorCommand.cpp:307
> +        // We need to keep a reference, because insertNodeAt might fail to insert the node.
> +        auto protectedBr = br;

Instead of this, can we just br.copyRef() in insertNodeAt?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210126/9c326a03/attachment-0001.htm>