[Webkit-unassigned] [Bug 220925] [webkit-patch] Allow user to opt out of browser for viewing the diff

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=220925

--- Comment #6 from Angelos Oikonomopoulos <angelos at igalia.com> ---
(In reply to Alexey Proskuryakov from comment #5)
> > The motivating use case is that the user does want to see the diff, except
> > not in a browser. This may be the case when they're connected over ssh to a
> > remote box that has a text-mode browser installed for other reasons, but the
> > diff is not really viewable in the text-mode browser.
> 
> Is there a way to detect this automatically?

I'm not sure what 'this' refers to here.

> There probably is one on macOS
> at least, although I'm do not know how exactly. The design of this function
> is that webbrowser.get() raises an exception when it's not available, so
> this is probably where the check for WEBKIT_PATCH_NO_BROWSER needs to go, if
> there is no automatic solution.

Not sure if I understand correctly; the reason I placed the check at the top of the function was to do what the name of the variable does, i.e. not use a browser regardless of if one is available or not. I should add that this also helps in the case where the user doesn't want to hunt for the new diff tab in their open browser windows but would rather see the diff "synchronously", i.e. in the terminal they're working in, in a pager.

> What is the failure behavior that you are currently observing?

The failure is that if any text-mode browser is installed on the machine that I've ssh'd in to, then running webkit-patch will show me the diff in that browser, however the diff is not readable in a text-mode browser.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210125/a43a4ad2/attachment.htm>