[Webkit-unassigned] [Bug 220925] [webkit-patch] Allow user to opt out of browser for viewing the diff

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=220925

--- Comment #3 from Angelos Oikonomopoulos <angelos at igalia.com> ---
(In reply to Jonathan Bedard from comment #2)
> Comment on attachment 418293 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=418293&action=review
> 
> > Tools/Scripts/webkitpy/common/system/user.py:175
> > +            return False
> 
> Not against this in principle...is the rationale that the user does not want
> to see the diff (even though they have a browser) or that the user does not
> have a browser installed? If it's the latter, what does this function
> actually do?

The motivating use case is that the user does want to see the diff, except not in a browser. This may be the case when they're connected over ssh to a remote box that has a text-mode browser installed for other reasons, but the diff is not really viewable in the text-mode browser.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210125/ce92fcba/attachment-0001.htm>