[Webkit-unassigned] [Bug 220773] [Cocoa] Web Inspector: Console search box is broken, advancing to next result instead pastes from system find pasteboard

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=220773

--- Comment #4 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 418313
  --> https://bugs.webkit.org/attachment.cgi?id=418313
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418313&action=review

> Source/WebInspectorUI/UserInterface/Views/LogContentView.js:64
>          this._findBanner = new WI.FindBanner(this, "console-find-banner", fixed);

Instead of modifying `showing` to have all this other logic and modification sites, can we instead save `fixed` and use it inside `set targetElement` like so
```
-        this._targetElement.classList.remove(WI.FindBanner.ShowingFindBannerStyleClassName);
+        this._targetElement.classList.toggle(WI.FindBanner.ShowingFindBannerStyleClassName, this._fixed);
```

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210125/fd949741/attachment.htm>