[Webkit-unassigned] [Bug 220733] [css-grid] max-height percentages are wrongly resolved for replaced grid items

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=220733

Manuel Rego Casasnovas <rego at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #418148|review?                     |review+
              Flags|                            |

--- Comment #9 from Manuel Rego Casasnovas <rego at igalia.com> ---
Comment on attachment 418148
  --> https://bugs.webkit.org/attachment.cgi?id=418148
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418148&action=review

r=me, thanks for the changes.

> Source/WebCore/rendering/RenderBox.cpp:3187
> +        if (overridingContainingBlockContentLogicalHeight() == LayoutUnit(-1))
> +            return true;
> +        return false;

Nit: It's more common to write this like:
    return overridingContainingBlockContentLogicalHeight() == LayoutUnit(-1);

In that case you won't need the braces on the if either.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210125/d4791f44/attachment.htm>