[Webkit-unassigned] [Bug 191463] [css-grid][css-flex] <table> grid item should fill the grid area for 'stretch'/'normal' self alignment

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 25 03:25:53 PST 2021


https://bugs.webkit.org/show_bug.cgi?id=191463

--- Comment #4 from Javier Fernandez <jfernandez at igalia.com> ---
Comment on attachment 418110
  --> https://bugs.webkit.org/attachment.cgi?id=418110
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418110&action=review

>> Source/WebCore/rendering/RenderTable.cpp:243
>> +        // needed and that we're not skipping anything essential due to the early return here.
> 
> WebKit uses FIXME instead of TODO(name). In any case I think we can completely remove it at this point.
> 
> In any case I am not sure about the change itself because this is skipping the table width calculation for all the cases when the table is a grid item, but if the grid item is not stretched then we do need this computation because we need the table intrinsic size.

I think the change is correct, at least for the cases we were testing in blink. The idea is that in case the table has justify-self different from auto/stretch, we use the LayoutBox logic, which will eventually run the PreferredLogicalWidth call. However, as the table is a grid item, it should use its corresponding grid area as "container" when computing the available size. 

The FIXME still stands, because while I think the current RenderGrid logic deals with this correctly for regular boxes as grid item, I'm not completely sure it covers all the peculiarities a table could have (eg. margins, padding, ...)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210125/bb92de29/attachment.htm>


More information about the webkit-unassigned mailing list