[Webkit-unassigned] [Bug 191463] [css-grid][css-flex] <table> grid item should fill the grid area for 'stretch'/'normal' self alignment

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=191463

--- Comment #3 from Sergio Villar Senin <svillar at igalia.com> ---
(In reply to Sergio Villar Senin from comment #2)
> Comment on attachment 418110 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=418110&action=review
> 
> > Source/WebCore/ChangeLog:15
> > +        grid are imported.
> 
> In the Blink patch the author was also unskipping some other tests that are
> not imported in WebKit tree yet, we should probably do that before landing
> this change or even as part of this change.

I think I messed it up, the other tests are for flexbox, sorry about the noise.

> 
> > Source/WebCore/rendering/RenderTable.cpp:243
> > +        // needed and that we're not skipping anything essential due to the early return here.
> 
> WebKit uses FIXME instead of TODO(name). In any case I think we can
> completely remove it at this point.
> 
> In any case I am not sure about the change itself because this is skipping
> the table width calculation for all the cases when the table is a grid item,
> but if the grid item is not stretched then we do need this computation
> because we need the table intrinsic size.

Looks like RenderBox ends up calling the preferred logical widths computation in any case so I guess this should indeed work. Let me just review again the test in order to fully understand what's going on.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210125/99688037/attachment-0001.htm>