[Webkit-unassigned] [Bug 220365] [JSC] Allow to build WebAssembly without B3

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=220365

--- Comment #19 from Don Olmstead <don.olmstead at sony.com> ---
Comment on attachment 418144
  --> https://bugs.webkit.org/attachment.cgi?id=418144
Make Wasm/B3 a compile-time option, v11

View in context: https://bugs.webkit.org/attachment.cgi?id=418144&action=review

> Source/JavaScriptCore/wasm/WasmB3IRGenerator.cpp:70
> +#if !ENABLE(WEBASSEMBLY)
> +#error ENABLE(WEBASSEMBLY_B3JIT) is enabled, but ENABLE(WEBASSEMBLY) is not.
> +#endif
> +

You probably want this check in wtf/PlatformEnable.h.

See https://github.com/WebKit/WebKit/blob/main/Source/WTF/wtf/PlatformEnable.h#L861-L881 for examples.

> Source/WTF/wtf/PlatformEnable.h:685
>  #if !defined(ENABLE_WEBASSEMBLY) && (ENABLE(B3_JIT) && PLATFORM(COCOA) && CPU(ADDRESS64))
>  #define ENABLE_WEBASSEMBLY 1
> +#define ENABLE_WEBASSEMBLY_B3JIT 1
>  #endif

Just a thought but would it be better to move this later and do the following?

#if !defined(ENABLE_WEBASSEMBLY_B3JIT) && (ENABLE(WEBASSEMBLY) && ENABLE(B3_JIT))
#define ENABLE_WEBASSEMBLY_B3JIT 1
#endif

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210122/8f1999a4/attachment.htm>