[Webkit-unassigned] [Bug 220733] [css-grid] max-height percentages are wrongly resolved for replaced grid items

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=220733

--- Comment #7 from Manuel Rego Casasnovas <rego at igalia.com> ---
Comment on attachment 418050
  --> https://bugs.webkit.org/attachment.cgi?id=418050
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=418050&action=review

> Source/WebCore/ChangeLog:10
> +        if not in quirk mode.

Nit: s/quirk/quirks/

> Source/WebCore/rendering/RenderBox.cpp:3188
> +        if (!document().inQuirksMode())
> +            return false;

I'm still curious, do we need this check?

I don't remember how grid works (if any) in quirk modes.

Could you verify if this code is used and if it has any effect depending on being on quirks mode or not? Thanks.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210122/2b19ecb0/attachment.htm>