[Webkit-unassigned] [Bug 220366] REGRESSION(r270074): [WPE][GTK] Problems when creating SoupServer in WebKitTestServer::WebKitTestServer

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=220366

Carlos Garcia Campos <cgarcia at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cgarcia at igalia.com,
                   |                            |clopez at igalia.com,
                   |                            |dpino at igalia.com,
                   |                            |lmoura at igalia.com

--- Comment #1 from Carlos Garcia Campos <cgarcia at igalia.com> ---
The soup server impl is indeed very broken. I also don't understand how it can work in the bots and EWS. I'm not sure it's worth reverting the original commits or just fix current impl at this point. In any case we should make sure the bots are running the actual code and not an old version or whatever is going on.

Michael's patch looks good, but it0's not enough:

1- We are assuming soup_server_get_uris() returns a list og objects, but SoupURI is not an object. That means we should use soup_uri_copy instead of g_object_ref when setting m_baseURI (or steal the uri somehow) and soup_uri_free instead of g_object_ref when freeing the list.

2- We are still calling soup_server_run_async() that should only be called from the old API. We can just omit it, it's not needed with the new API.

Michael, could you submit a new patch with those things fixed, please?

Diego, Lauro or Carlos, could any of you check why tests are running fine in the bots, please?

Thanks!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210121/dce06b23/attachment.htm>