[Webkit-unassigned] [Bug 220657] [css-grid] Relayout grid items when definiteness changes.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=220657

--- Comment #9 from zsun at igalia.com ---
(In reply to Manuel Rego Casasnovas from comment #7)
> Comment on attachment 417965 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=417965&action=review
> 
> > Source/WebCore/ChangeLog:11
> > +        Reviewed by NOBODY (OOPS!).
> 
> Nit: This line is wrongly placed.
> 
> > Source/WebCore/ChangeLog:12
> > +
> 
> Pleaes describe here what the patch is doing. Despite the link to the
> Chromium patch, it's good to describe things for the change in WebKit as
> it's not totally equivalent.
> 
> > Source/WebCore/ChangeLog:14
> > +               imported/w3c/web-platform-tests/css/css-grid/relative-grandchild.html
> 
> It looks like Chromium change also has some effects on
> css/css-grid/grid-child-percent-basis-resize-1.html test, have you checked
> that on WebKit?
> 
> > Source/WebCore/rendering/RenderGrid.cpp:1144
> > +        // Checking the logical-height of a child isn't enough. Setting an override
> > +        // logical-height changes the definiteness, resulting in percentages to
> > +        // resolve differently.
> 
> Nit: In WebKit you don't need to wrap comments in 80-columns.

Comments have been addressed. Thank you!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210121/7bb9e2cb/attachment-0001.htm>