[Webkit-unassigned] [Bug 220657] [css-grid] Relayout grid items when definiteness changes.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=220657

--- Comment #6 from zsun at igalia.com ---
(In reply to Oriol Brufau from comment #4)
> Comment on attachment 417863 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=417863&action=review
> 
> > Source/WebCore/rendering/RenderGrid.cpp:1147
> > +        if (desiredLogicalHeight != child.logicalHeight() || child.maybeHasPercentHeightDescendant()) {
> 
> I think it may be possible to use hasPercentHeightDescendant() instead of
> adding maybeHasPercentHeightDescendant()
> In Chromium this wasn't possible because of this quirk:
> https://quirks.spec.whatwg.org/#the-percentage-height-calculation-quirk
> But WebKit doesn't seem to use the quirk for grid according to the image in
> https://github.com/w3c/csswg-drafts/issues/5545
> 
Updated

> > Source/WebCore/rendering/RenderGrid.cpp:1149
> >              child.setNeedsLayout(MarkOnlyThis);
> 
> Just noting that the relayout can worsen performance for deeply nested grids.
> https://bugs.chromium.org/p/chromium/issues/detail?id=1146377#c2
> 
> Though it doesn't seem possible to do the right thing in a performant way
> with this rendering engine. Chromium will only address the performance
> problem in LayoutNG.
> 
> > LayoutTests/imported/w3c/ChangeLog:5
> > +
> 
> Nit: can you mention that you are importing tests, not creating new ones?
> 

Added

> > LayoutTests/imported/w3c/web-platform-tests/css/css-grid/relative-grandchild-expected.xht:5
> > +  <link rel="author" title="Gérard Talbot" href="http://www.gtalbot.org/BrowserBugsSection/css21testsuite/" />
> 
> Bad text encoding in "Gérard"?

Not sure why. It seems displaying fine for me.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210120/7c78a987/attachment-0001.htm>