[Webkit-unassigned] [Bug 220509] [SOUP] Stop using SoupRequest API to load files in preparation for libsoup3

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=220509

--- Comment #3 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 417376
  --> https://bugs.webkit.org/attachment.cgi?id=417376
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417376&action=review

>> Source/WebKit/NetworkProcess/soup/NetworkDataTaskSoup.cpp:259
>> +        else if (m_file) {
> 
> I checked the code a bit, and IIUC it looks like only one of m_inputStream,
> m_multipartInputStream, m_soupRequest, or m_file can be valid at a time. It
> would be nice to convert this to use std::variant<…> at some point — but of
> course that's out of the scope of this patch, and we would need to build in
> C++17 mode first ��️

Well, we have Variant in WTF, but that would be out of scope of this patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210120/0c9fbd08/attachment.htm>