[Webkit-unassigned] [Bug 219177] zero boundingRect pointer in Font::platformBoundsForGlyph() to CTFontGetBoundingRectsForGlyphs()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=219177

--- Comment #13 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 417743
  --> https://bugs.webkit.org/attachment.cgi?id=417743
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=417743&action=review

>>> Source/WebCore/platform/graphics/coretext/FontCoreText.cpp:702
>>> +    CGRect ignoredRect = { };
>> 
>> No reason for the "= { }". The name emptyRect confused me into thinking it was needed. So the only thing wrong was the name, the code was totally fine. This patch is OK as is, but also one that just ranges would be fine. And the bug could be retitled since this is just naming clarity, no need to zero anything.
> 
> that just *renames*, not that just *ranges*

It's probably still a good practice to zero it out so that there is no ambiguity we won't have indeterministic behavior here.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210116/9a42c21c/attachment.htm>