[Webkit-unassigned] [Bug 220241] Web Inspector: RTL content inside elements is reversed and unreadable
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jan 13 08:08:39 PST 2021
https://bugs.webkit.org/show_bug.cgi?id=220241
Sam Sneddon [:gsnedders] <gsnedders at apple.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |gsnedders at apple.com
--- Comment #7 from Sam Sneddon [:gsnedders] <gsnedders at apple.com> ---
We previously fixed a similar issue in bug 170298 by adding bdo=auto to the DOM tree (which in the UA stylesheet adds unicode-bidi: isolate).
Bug 207214, which introduced this regression, was outright wrong using isolate-override (it only makes sense in combination with an explicitly set direction, which we don't have for page content). In general, using the dir attribute (and potentially the bdo/bdi elements) is recommended given it's generally more obvious about what it does.
There's probably a strong argument that if the page has <span dir=rtl>foo</span> then we want to end up with <span class="html-text-node" dir=rtl>foo</span> in the Inspector, rather than using auto there. That said, with the patch attached to this bug, we're in a better place than before bug 207214, so I'm a non-reviewer r+ on this.
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210113/40bdfc52/attachment.htm>
More information about the webkit-unassigned
mailing list