[Webkit-unassigned] [Bug 220412] [JSC] Implement a B3::ValueRep replacement for wasm-llint

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=220412

--- Comment #5 from Xan Lopez <xan.lopez at gmail.com> ---
(In reply to Saam Barati from comment #4)
> Comment on attachment 417453 [details]
> WIP patch.
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=417453&action=review
> 
> > Source/JavaScriptCore/wasm/WasmValueLocation.h:65
> > +    static ValueLocation stack(intptr_t offsetFromFP)
> 
> do we really need this and stackArgument?

All three 'kinds' left in the class (reg, stack, stackArgument) are used in WasmCallingConvention (see marshallLocationImpl), if that's what you are asking. If you mean whether the class *really* needs that, not sure. The code seems sensible enough, but it's the first time I work on it.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210113/c8966845/attachment.htm>