[Webkit-unassigned] [Bug 220407] [GStreamer] Do not use the registry scanner singleton from the UI process

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=220407

--- Comment #3 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to Víctor M. Jáquez L. from comment #2)
> Comment on attachment 417173 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=417173&action=review
> 
> > Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.h:44
> > +    ~GStreamerRegistryScanner() = default;
> 
> I wonder if it 's worth to have a 
> 
> if (!isInWebProcess())
>     gst_deinit()
> 
> In the destructor

No, init and deinit are not balanced. It's ok to call init even if the app already called it, because it does nothing, but not the other way around.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210111/3d510c98/attachment.htm>