[Webkit-unassigned] [Bug 220314] [WASM-References] Add linking tests

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=220314

Yusuke Suzuki <ysuzuki at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ysuzuki at apple.com
 Attachment #416979|review?, commit-queue?      |review+, commit-queue-
              Flags|                            |

--- Comment #2 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 416979
  --> https://bugs.webkit.org/attachment.cgi?id=416979
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416979&action=review

r=me, but we need to have bugzilla links.

> JSTests/wasm/references-spec-tests/linking.wast.js:269
> +// FIXME: should be uninstantiable - https://github.com/WebAssembly/bulk-memory-operations/issues/133. should be uninstantiable - https://github.com/WebAssembly/bulk-memory-operations/issues/133.

When commenting out wasm spec test, we should have bugzilla URL with FIXME which clarifies what is the problem and how we will fix in the future.
And the comment has duplicate information twice.

> JSTests/wasm/references-spec-tests/linking.wast.js:279
> +// FIXME: should be uninstantiable - https://github.com/WebAssembly/bulk-memory-operations/issues/133.

Ditto.

> JSTests/wasm/references-spec-tests/linking.wast.js:290
> +// FIXME: should be uninstantiable - https://github.com/WebAssembly/bulk-memory-operations/issues/133.

Ditto.

> JSTests/wasm/references-spec-tests/linking.wast.js:353
> +// FIXME: should be uninstantiable - https://github.com/WebAssembly/bulk-memory-operations/issues/133.

Ditto.

> JSTests/wasm/references-spec-tests/linking.wast.js:391
> +// FIXME: should be uninstantiable - https://github.com/WebAssembly/bulk-memory-operations/issues/133.

Ditto.

> JSTests/wasm/references-spec-tests/linking.wast.js:402
> +// FIXME: should be uninstantiable - https://github.com/WebAssembly/bulk-memory-operations/issues/133.

Ditto.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210106/305fd313/attachment-0001.htm>