[Webkit-unassigned] [Bug 220323] [WASM-References] Add optional default value parameter for Table.grow

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=220323

--- Comment #3 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 416994
  --> https://bugs.webkit.org/attachment.cgi?id=416994
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416994&action=review

>> Source/JavaScriptCore/wasm/js/WebAssemblyTablePrototype.cpp:100
>>          return JSValue::encode(throwException(globalObject, throwScope, createRangeError(globalObject, "WebAssembly.Table.prototype.grow could not grow the table"_s)));
> 
> I think this has a bug.
> If table is function ref table, then values that can be configured to the table is limited.
> Can you align the implementation to the spec's change? https://webassembly.github.io/reference-types/js-api/index.html#dom-table-grow
> 
> 5. If value is missing,
> 5.1. Let ref be DefaultValue(elementType).
> 6. Otherwise,
> 6.1. Let ref be ? ToWebAssemblyValue(value, elementType).

And can you add tests for the above thing :) ?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210106/b3b23671/attachment-0001.htm>