[Webkit-unassigned] [Bug 220235] [WASM-References] Fix data section parsing and add more tests from ref-types

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 4 10:04:40 PST 2021


https://bugs.webkit.org/show_bug.cgi?id=220235

Yusuke Suzuki <ysuzuki at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ysuzuki at apple.com
 Attachment #416931|                            |review+
              Flags|                            |

--- Comment #2 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 416931
  --> https://bugs.webkit.org/attachment.cgi?id=416931
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=416931&action=review

r=me with comment.

> Source/JavaScriptCore/wasm/WasmSectionParser.cpp:747
> +        const char* errorMessage = Options::useWebAssemblyReferences() ? "th Data segment's flag" : "th Data segment's index";

I think we should just throw an error with `"th Data segment's flag"`.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210104/e3c001f9/attachment.htm>


More information about the webkit-unassigned mailing list