[Webkit-unassigned] [Bug 222508] Support fast/canvas/webgl/copyBufferSubData.html, fix bugs in fast/canvas/webgl/getBufferSubData-webgl1.html in Metal ANGLE on Simulator

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=222508

Dean Jackson <dino at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #421731|review?                     |review+
              Flags|                            |

--- Comment #3 from Dean Jackson <dino at apple.com> ---
Comment on attachment 421731
  --> https://bugs.webkit.org/attachment.cgi?id=421731
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=421731&action=review

> Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/BufferMtl.mm:233
> +    if(result)

Nit: Space before (

> Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/DisplayMtl.mm:331
> +#else //Simulator should be able to support ES3, despite not supporting ios family 4 in it's entirety.

Nit: Space after // and s/it's/its/

I'll fix these when landing.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210227/e467e04a/attachment.htm>