[Webkit-unassigned] [Bug 222448] [MSE] Overlapping MediaSamples are not deleted

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=222448

--- Comment #4 from Jer Noble <jer.noble at apple.com> ---
Comment on attachment 421614
  --> https://bugs.webkit.org/attachment.cgi?id=421614
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=421614&action=review

> Source/WebCore/platform/graphics/SourceBufferPrivate.cpp:1141
> -        // If highest presentation timestamp for track buffer is set and less than or equal to presentation timestamp
> -        if (trackBuffer.highestPresentationTimestamp.isValid() && trackBuffer.highestPresentationTimestamp - contiguousFrameTolerance <= presentationTimestamp) {
> +        // If highest presentation timestamp for track buffer is set and less than frame end timestamp.
> +        if (trackBuffer.highestPresentationTimestamp.isValid() && trackBuffer.highestPresentationTimestamp - contiguousFrameTolerance < frameEndTimestamp) {

This text comes directly from the MSE standard, and it looks like it has been changed since this comment was written.  The new text of "3.5.8 Coded Frame Processing" step 1.14, part 2 says:

> If highest end timestamp for track buffer is set and less than or equal to presentation timestamp:

It looks like we do correctly set "highestPresentationTimestamp" to the "frame end timestamp" later in step 1.19, but I do wonder if there were other changes to the specification around "frame end timestamp" that may have been missed. So your proposed change would be a willful departure from the text of the specification. Should this be brought up to the MSE spec authors first?  Or is there another way to solve the issue you're attempting to fix?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210226/b8715757/attachment.htm>