[Webkit-unassigned] [Bug 191627] [css-grid] Incorrect track sizing when using relative sized items in 'auto' column tracks

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=191627

--- Comment #13 from Javier Fernandez <jfernandez at igalia.com> ---
Comment on attachment 421640
  --> https://bugs.webkit.org/attachment.cgi?id=421640
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=421640&action=review

>> Source/WebCore/rendering/RenderBox.cpp:2046
>> +        return overridingContainingBlockContentLogicalWidth().valueOr(LayoutUnit());
> 
> Hmm if hasOverridingContainingBlockContentLogicalWidth() is true then we know that it has a value, then why do we need the valueOr() ?

No, the HasOverrideXXX function only tells whether a value has been set (which is always true for grid items), bit it might be nullopt (to specify indefinite size)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210226/0d6d78ae/attachment-0001.htm>