[Webkit-unassigned] [Bug 188111] REGRESSION(r263094): [GTK][WPE] API test /webkit/WebKitWebContext/languages is failing

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 25 23:10:24 PST 2021


https://bugs.webkit.org/show_bug.cgi?id=188111

--- Comment #10 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to Chris Dumez from comment #9)
> Comment on attachment 421392 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=421392&action=review
> 
> > Source/WebKit/UIProcess/WebProcessPool.cpp:-308
> > -    addLanguageChangeObserver(this, languageChanged);
> 
> I don't understand why we are getting rid of the language change observer in
> the UIProcess. Seems like we would want to know and notify the WebProcesses
> if the user changed the language, no?

Because after this patch overrideUserPreferredLanguages() is no longer called from the UI process. Right now is only called from the GLib API, unless I'm missing something.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210226/3aa3a3aa/attachment.htm>


More information about the webkit-unassigned mailing list