[Webkit-unassigned] [Bug 222412] Add type method for WASM Global, Memory and Table JS API classes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=222412

Yusuke Suzuki <ysuzuki at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ysuzuki at apple.com

--- Comment #3 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 421514
  --> https://bugs.webkit.org/attachment.cgi?id=421514
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=421514&action=review

Commented.

> Source/JavaScriptCore/wasm/js/JSWebAssemblyGlobal.cpp:115
> +    default:
> +        RELEASE_ASSERT_NOT_REACHED();
> +    }

We need to handle all types that are supported in WebAssembly.Global (e.g. funcref).

> Source/JavaScriptCore/wasm/js/WebAssemblyGlobalPrototype.cpp:90
> +    return JSValue::encode(global->type(globalObject));

Use
RELEASE_AND_RETURN(throwScope, JSValue::encode(global->type(globalObject)));

> Source/JavaScriptCore/wasm/js/WebAssemblyMemoryPrototype.cpp:112
> +    JSObject* memoryType = memory->type(globalObject);
> +    RETURN_IF_EXCEPTION(throwScope, { });
> +
> +    RELEASE_AND_RETURN(throwScope, JSValue::encode(memoryType));

Do,

RELEASE_AND_RETURN(throwScope, JSValue::encode(memory->type(globalObject)));

> Source/JavaScriptCore/wasm/js/WebAssemblyTablePrototype.cpp:178
> +    JSObject* tableType = table->type(globalObject);
> +    return JSValue::encode(tableType);

Do

RELEASE_AND_RETURN(throwScope, JSValue::encode(table->type(globalObject)));

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210226/7f80656e/attachment.htm>