[Webkit-unassigned] [Bug 222331] Fix MetalANGLE backend crashes in video texture tests

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 25 15:15:39 PST 2021


https://bugs.webkit.org/show_bug.cgi?id=222331

Dean Jackson <dino at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #421569|review?                     |review+
              Flags|                            |

--- Comment #4 from Dean Jackson <dino at apple.com> ---
Comment on attachment 421569
  --> https://bugs.webkit.org/attachment.cgi?id=421569
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=421569&action=review

> Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/IOSurfaceSurfaceMtl.mm:43
> +// clang-format off

Did you mean to leave this in?

> Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/TextureMtl.mm:674
> +    if(mState.getType() == gl::TextureType::Rectangle)
> +    {
> +        samplerDesc.normalizedCoordinates = NO;
> +    }
> +    else
> +    {
> +        samplerDesc.normalizedCoordinates = YES;
> +    }

Use a ternary?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210225/4805b7e1/attachment.htm>


More information about the webkit-unassigned mailing list