[Webkit-unassigned] [Bug 221912] [LayoutTests] Convert http/tests/websocket convert PHP to Python

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=221912

--- Comment #6 from Jonathan Bedard <jbedard at apple.com> ---
Comment on attachment 420347
  --> https://bugs.webkit.org/attachment.cgi?id=420347
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=420347&action=review

> LayoutTests/http/tests/websocket/tests/hybi/contentextensions/block-cookies-worker.py:11
> +exp_time = datetime.utcnow() - timedelta(hours=1)

Shouldn't this be a +?

> LayoutTests/http/tests/websocket/tests/hybi/contentextensions/block-cookies-worker.py:19
> +    )

I would do the early return here and git rid of the "else". It makes the multi-line string confusing.

> LayoutTests/http/tests/websocket/tests/hybi/contentextensions/block-cookies.py:19
> +    )

Again, I would do the early exit here and ditch the else statement entirely.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210225/81b9708e/attachment-0001.htm>