[Webkit-unassigned] [Bug 222376] [css-grid] Replace the use of -1 with WTF::nullopt

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=222376

--- Comment #2 from Javier Fernandez <jfernandez at igalia.com> ---
Comment on attachment 421441
  --> https://bugs.webkit.org/attachment.cgi?id=421441
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=421441&action=review

I bealive there are other functions using -1 as indefinite; I think this patch should address all of them. 

See GridTrackSizingAlgorithm::estimatedGridAreaBreadthForChild for instance.

> Source/WebCore/ChangeLog:7
> +

We should explain for each change why we need nullopt instead; those functions return an Optional type and we consider nullopt as indefinite, as we did before with the -1 value. 

It's also need to mention why this change doesn't need new tests, or changes on the already existing ones.
In this case, since we don't expect a behavior change, we don't need to provide tests.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210225/8f284340/attachment.htm>