[Webkit-unassigned] [Bug 222100] [css-grid] Fix min/max widths of grid affected by ancestor

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=222100

--- Comment #8 from zsun at igalia.com ---
(In reply to Javier Fernandez from comment #6)
> Comment on attachment 421305 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=421305&action=review
> 
> > Source/WebCore/rendering/RenderBox.cpp:2479
> > +        // If the preferred widths are already dirty at this point (during layout), it actually means that we never need to calculate them, since that should
> 
> I think we can move the comments above the if clause, and remove the
> brackets.
> 
> > Source/WebCore/rendering/RenderBox.cpp:2485
> > +        // If our containing block also has min/max widths that are affected by the ancestry, we have already dealt with this object as well. Avoid
> 
> Ditto
> 
> > Source/WebCore/rendering/RenderBox.cpp:2496
> > +        if (shouldRecalculateMinMaxWidthsAffectedByAncestor(this)) {
> 
> Why not using a composed conditional clause instead two nested if ?
> 
> > Source/WebCore/rendering/RenderBox.cpp:2497
> > +        // Laying out this object means that its containing block is also being laid out. This object is special, in that its min/max widths depend on
> 
> We could move the comments here as well, as I suggested before.

All review comments have been addressed. Thank you!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210223/45c025ef/attachment-0001.htm>