[Webkit-unassigned] [Bug 222100] [css-grid] Fix min/max widths of grid affected by ancestor

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=222100

--- Comment #3 from Javier Fernandez <jfernandez at igalia.com> ---
Comment on attachment 420837
  --> https://bugs.webkit.org/attachment.cgi?id=420837
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=420837&action=review

> Source/WebCore/ChangeLog:9
> +        Before update logical-width, for element that needs prefrredWidth recalcution,

s/prefrredWidth/preferredWidth

> Source/WebCore/rendering/RenderBox.cpp:2485
> +        if (cb->needsPreferredWidthsRecalculation() && !box->preferredLogicalWidthsDirty()) {

I supposed box->preferredLogicalWidthsDirty() is false for sure, otherwise we should have entered in the branch above, right ? 

Perhaps you meant "cb->" here ? Just wondering.

> Source/WebCore/rendering/RenderBox.cpp:2498
> +        // Laying out this object means that its containing block is also being laid out. This object is special, in that its min/max widths depend on

Nit, I think it'd be clearer if we put the comment just above the if statement.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210222/3e9a4ac5/attachment-0001.htm>