[Webkit-unassigned] [Bug 222125] New: AX: Update macOS attribute initializers to be more modern

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=222125

            Bug ID: 222125
           Summary: AX: Update macOS attribute initializers to be more
                    modern
           Product: WebKit
           Version: WebKit Nightly Build
          Hardware: All
                OS: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Accessibility
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: cfleizach at apple.com
                CC: webkit-bug-importer at group.apple.com

> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:1601
> +        auto tempArray = adoptNS([[NSMutableArray alloc] initWithArray:attributes]);
> +        [tempArray addObject:NSAccessibilityEmbeddedImageDescriptionAttribute];
> +        [tempArray addObject:NSAccessibilityURLAttribute];
> +        imageAttrs = tempArray.leakRef();
> +    }


adoptNS(...).leakRef() seems to be a no-op, so I'm not sure what it's doing here. This applies to all the other initializers in this function as well.

Additionally, it's a little weird that every attribute dictionary is initialized the first time this method is called, rather than have a separate static/NeverDestroyed method for each, so the cost is only paid when at item of the specific type is passed in.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210218/ad320637/attachment-0001.htm>