[Webkit-unassigned] [Bug 221337] Fix replaced element definiteness as a grid-item

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=221337

--- Comment #5 from zsun at igalia.com ---
(In reply to Javier Fernandez from comment #3)
> Comment on attachment 419408 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=419408&action=review
> 
> > Source/WebCore/ChangeLog:9
> > +        has an indefinite containing-block override logical-height.
> 
> I think it'd be useful to know why we need to return false for replaced grid
> items. Perhaps an excerpt of the spec and a link to the section where it's
> stated.
> 

Updated. 
> > Source/WebCore/rendering/RenderBoxModelObject.cpp:285
> > +        return thisBox->overridingContainingBlockContentLogicalHeight() == WTF::nullopt;
> 
> I don't understand why this change affects only to replaced grid items.
> Could you please elaborate on this ?

I think function hasAutoHeightOrContainingBlockWithAutoHeight() is only called by replaced handlers, right? I'm not sure why it's only for grid items though.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210216/32f9f40c/attachment.htm>