[Webkit-unassigned] [Bug 221337] Fix replaced element definiteness as a grid-item

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=221337

--- Comment #3 from Javier Fernandez <jfernandez at igalia.com> ---
Comment on attachment 419408
  --> https://bugs.webkit.org/attachment.cgi?id=419408
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=419408&action=review

> Source/WebCore/ChangeLog:9
> +        has an indefinite containing-block override logical-height.

I think it'd be useful to know why we need to return false for replaced grid items. Perhaps an excerpt of the spec and a link to the section where it's stated.

> Source/WebCore/rendering/RenderBoxModelObject.cpp:285
> +        return thisBox->overridingContainingBlockContentLogicalHeight() == WTF::nullopt;

I don't understand why this change affects only to replaced grid items. Could you please elaborate on this ?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210215/255601d8/attachment.htm>