[Webkit-unassigned] [Bug 221225] Implement WebXR getViewerPose and getPose

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=221225

--- Comment #7 from youenn fablet <youennf at gmail.com> ---
(In reply to Imanol Fernandez from comment #6)
> Comment on attachment 420125 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=420125&action=review
> 
> >> Source/WebCore/Modules/webxr/WebXRBoundedReferenceSpace.cpp:41
> >> +Ref<WebXRBoundedReferenceSpace> WebXRBoundedReferenceSpace::create(Document& document, WeakPtr<WebXRSession>&& session, XRReferenceSpaceType type)
> > 
> > I would pass a WebXRSession& if possible.
> 
> I don't think it's safe because JS can hold XRSpace instances after a
> XRSession is destroyed.

I was meaning to pass a WebXRSession& but store a WeakPtr<>.
This makes it clear for instance that session cannot be null.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210215/613242b7/attachment.htm>