[Webkit-unassigned] [Bug 221720] [LayoutTests] Convert http/tests/storageAccess convert PHP to Python

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=221720

--- Comment #8 from Chris Gambrell <cgambrell at apple.com> ---
(In reply to Jonathan Bedard from comment #6)
> Comment on attachment 420134 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=420134&action=review
> 
> > LayoutTests/http/tests/storageAccess/resources/get-cookies.py:29
> > +        print('Received cookie named \'{}\'.<br>'.format(name), end='')
> 
> Looks like the code I have you wasn't 100% correct, this seems to be what's
> causing the test failure EWS is flagging.

The for loop in the cookie header separation is still required...

for cookie in header_cookies:
        cookie = cookie.split('=')
        cookies[cookie[0]] = cookie[1]

...due to needing to separate...

['foo=bar', 'hello=world']

...into...

{
    'foo': 'bar',
    'hello: 'world'
}

Fixed that in latest patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210212/c784acf5/attachment-0001.htm>