[Webkit-unassigned] [Bug 219194] the nested grid container which has replaced item with 'max-height' has wrong width(0px).

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 11 01:14:48 PST 2021


https://bugs.webkit.org/show_bug.cgi?id=219194

--- Comment #16 from Sergio Villar Senin <svillar at igalia.com> ---
Comment on attachment 419892
  --> https://bugs.webkit.org/attachment.cgi?id=419892
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=419892&action=review

> Source/WebCore/rendering/RenderReplaced.cpp:798
> +    return hasRelativeLogicalHeight() && style().logicalWidth().isAuto();

I know I'm already too late here but shouldn't we check that the replaced element does indeed have an aspect ratio? Being a replaced element does not imply that it has an aspect ratio.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20210211/47b984e0/attachment-0001.htm>


More information about the webkit-unassigned mailing list